[PATCH] D25476: GVN-hoist: fix store past load dependence analysis (PR30216, PR30499)

[Sebastian Pop via llvm-commits]

sebpop added inline comments.


================
Comment at: llvm/include/llvm/Transforms/Utils/MemorySSA.h:977
 
+bool instructionClobbersQuery(MemoryDef *MD,
+                              const MemoryLocation &UseLoc,
----------------
dberlin wrote:
> I would really rather not expose this version.
> We should keep the interface as "memorydefs and memoryuses" as much as possible.
> 
> It also shouldn't be named instructionClobbersQuery.
> 
> 
> So i would expect this to be something like
> 
> bool defClobbersUseOrDef(MemoryDef *MD, MemoryUseOrDef *MU, AliasAnalysis &AA);
> 
> Internally, it obviously will just call a version of instructionClobbersQuery, but that should be an API implementation detail.
> I'm fine fixing this in a followup though.
> 
Committed the patch as r283965.
Committed the followup cleanup separately as r283967.



https://reviews.llvm.org/D25476