[PATCH] D24416: Unit test for Conditionally eliminate library calls

[Rong Xu via llvm-commits]

xur marked 2 inline comments as done.
xur added inline comments.


================
Comment at: SingleSource/Regression/C++/cdce_macro.inc:16
+
+#ifndef str
+#define str(s) s
----------------
davidxl wrote:
> use upper case for macro?
> 
> Why is the macro needed?
OK. used the upper case in the new patch.

We need this because, we need to postfix "l" or "f" to the name for long double and float. For double type, we don't need to do anything, that's the default here.


================
Comment at: SingleSource/Regression/C++/cdce_macro.inc:20
+
+#define RANGE 10
+#define TESTCODEVAL(FUNC, VAL)                                                 \
----------------
davidxl wrote:
> why 10 ?
just an arbitrary number. Do you want it to be a larger number? testing all the integers seems to be excessive.  


https://reviews.llvm.org/D24416