[PATCH] D25345: [ThinLTO] Handle empty summaries during internalization

[Teresa Johnson via llvm-commits]

tejohnson added a comment.

In https://reviews.llvm.org/D25345#567682, @mehdi_amini wrote:

> But my issue is not what `moduleCanBeRenamedForThinLTO()` does right now, but rather what do we do when it returns "false". These modules previously didn't go through the ThinLTO pipeline, so it was fine. Now they have an empty summary and they go to the thin-link. This seems an issue to me, and I rather have a proper answer design-wise rather than patching over-and-over as bugs are reported.


Note that the bug that is being fixes is not due to this model. We are just using the same model to address it as with inline assembly.

Agree that a better long term solution is needed soon, but in the meantime it would be good to be able to fix the module assembly issue now, since we already use this approach for inline assembly, and also address the difference in how this case is being handled here in internalization.


https://reviews.llvm.org/D25345