[PATCH] D25476: GVN-hoist: fix store past load dependence analysis (PR30216, PR30499)

Sebastian Pop via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 11 11:49:59 PDT 2016


On Tue, Oct 11, 2016 at 12:18 PM, Daniel Berlin <dberlin at dberlin.org> wrote:
>> > STH like:
>> >
>> > bool  MemorySSA::defClobbersUse(MemoryDef *MD, MemoryUse *MU) {
>> >    return instructionClobbersQuery(MD, MU, MemoryLocOrCall(MU),
>> > MSSA->AA);
>> > }
>> >
>>
>> That is not easy:
>
>
> Can you explain to me why?
> It seems pretty trivial.
>

Yes it is: I'll post an updated patch.
Sorry about this: I got confused by my previous attempt at fixing this.

>> Also one things is that in my use-case, both instructions would be
>> MemoryDefs,
>
>
> Err, in this use case, you are looking for loads that blocks stores, so now
> i'm confused.

We may be moving the store past either a load, a store, or a call.


More information about the llvm-commits mailing list