[PATCH] D25482: [PPC] Allow two post RA schedulers to be in the pipeline and select one depending on the Machine Function's subtarget

Matthias Braun via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 11 11:43:22 PDT 2016


MatzeB requested changes to this revision.
MatzeB added a reviewer: MatzeB.
MatzeB added a comment.
This revision now requires changes to proceed.

This adds a bunch of infrastructure in a bad way! This should be handled with a Subtarget callback like TargetSubtargetInfo::enablePostRAScheduler() which already exists!



================
Comment at: include/llvm/CodeGen/MachineFunctionPass.h:34
+
+  static char ID;
+
----------------
What is this good for? It seems unrelevant to the patch and this is just a base class nothing that can/should be scheduled or end up in the pass registry.


https://reviews.llvm.org/D25482





More information about the llvm-commits mailing list