[PATCH] D25461: LTO: Don't follow lazy references when seeing new definitions in the combined LTO object

[Peter Collingbourne via llvm-commits]

pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: test/COFF/lto-lazy-reference.ll:3
+; RUN: llvm-as -o %T/lto-lazy-reference-dummy.bc %S/Inputs/lto-lazy-reference-dummy.ll
+; RUN: llvm-ar cru %t.lib %T/lto-lazy-reference-quadruple.obj %T/lto-lazy-reference-dummy.bc
+; RUN: llvm-as -o %t.obj %s
----------------
We normally `rm -f` the archive file before creating it.


================
Comment at: test/COFF/lto-lazy-reference.ll:13
+  ; When compiled, this defines the __real at 40800000 symbol, which already has a
+  ; lazy definition in the lib file from  lto-real-quadruple.obj. This test
+  ; makes sure we *don't* try to take the definition from the lazy reference,
----------------
s/real/lazy-reference/


================
Comment at: test/COFF/lto-lazy-reference.ll:16
+  ; because that can bring in new references to bitcode files after LTO, such
+  ; as lto-real-dummy.bc in this case.
+  %mul = fmul double %x, 4.0
----------------
ditto


https://reviews.llvm.org/D25461