[PATCH] D14390: [mips] Expansion of LI.S and LI.D

Simon Dardis via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 11 07:24:01 PDT 2016


sdardis added inline comments.


================
Comment at: lib/Target/Mips/AsmParser/MipsAsmParser.cpp:197-201
+  
+  bool expandLoadImmReal(MCInst &Inst, bool IsSingle, bool IsGPR, bool Is64FPU,
+                         SMLoc IDLoc, MCStreamer &Out,
+                         const MCSubtargetInfo *STI);
 
----------------
sdardis wrote:
> There appears to be spurious white space on the line before this prototype, please remove it when you're committing.
It's actually whitespace, not the line I'm concerned about.


================
Comment at: lib/Target/Mips/AsmParser/MipsAsmParser.cpp:921
   }
+  
+  void addStrictlyAFGR64AsmRegOperands(MCInst &Inst, unsigned N) const {
----------------
sdardis wrote:
> Here too.
It's actually whitespace, not the line I'm concerned about.


https://reviews.llvm.org/D14390





More information about the llvm-commits mailing list