[PATCH] D24681: Optimize patterns of vectorized interleaved memory accesses for X86.

Farhana Aleen via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 10 21:07:16 PDT 2016


Farhana added a comment.

In https://reviews.llvm.org/D24681#566229, @mkuper wrote:

> I'm really sorry for coming into this review so late, but could you please also add stand-alone IR-level tests for the pass itself (and not only llc-level tests)?
>  Not only we'll get better testing granularity, but it'll be easier to see what the produced IR looks like, and whether it's really in the form we want.


Hi Michael,

So, you want me add an opt-based IR-level test, right?

But this InterleavedAccessPass is a CodegenPass, relies on target information and it gets added to the Codegen library by TargetPassConfig::addIRPasses(). On the other hand, opt relies on PassManagerBuilder and uses   Builder.populateFunctionPassManager(FPM) and

  Builder.populateModulePassManager(MPM) to construct it's list of passes to run.

llc uses TargetMachine::addPassesToEmitFile in order to get the backend passes.

clang supports both.

It is possible to at least support the IRPasses of Codegen in opt, but I am not sure whether that is the intent of opt. Also, even if we want that support I would guess you would want me to support that in a separate checkin?

Farhana


https://reviews.llvm.org/D24681





More information about the llvm-commits mailing list