[PATCH] D25433: [ELF] Don't crash if relocation target section is discarded

[Rui Ueyama via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/Symbols.cpp:57
+    if (!SC->Live) {
+      warn("relocation refers to discarded section");
+      return D.Value;
----------------
Please include a filename and symbol name in the error message.


================
Comment at: ELF/Symbols.cpp:58
+      warn("relocation refers to discarded section");
+      return D.Value;
+    }
----------------
Isn't it better to return 0 instead of D.Value?


Repository:
  rL LLVM

https://reviews.llvm.org/D25433