[PATCH] D25073: [DebugInfo]: preparation to implement DW_AT_alignment
Adrian Prantl via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 10 14:24:51 PDT 2016
aprantl added inline comments.
================
Comment at: lib/Bitcode/Writer/BitcodeWriter.cpp:1730
+ // 2) Record has artificial tag (Record[1]),
+ // has no obsolete inlignedAt field (Record[9]).
+ // In this case Record size will be 9, HasAlignment flag is false.
----------------
-> inlinedAt
================
Comment at: lib/Bitcode/Writer/BitcodeWriter.cpp:1737
+ // HasAlignment flag is true and Record[8] contains alignment value.
+ static const uint64_t HasAlignmentFlag = 1 << 1;
+ Record.push_back(N->isDistinct() | HasAlignmentFlag);
----------------
I don't think we want this to be static.
https://reviews.llvm.org/D25073
More information about the llvm-commits
mailing list