[PATCH] D25374: [DAGCombiner] Update most ADD combines to support general vector combines

Michael Kuperstein via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 10 13:16:12 PDT 2016


mkuper added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:832
+  if (ConstantSDNode *Const = dyn_cast<ConstantSDNode>(N))
+    return true;
+  if (N.getOpcode() != ISD::BUILD_VECTOR)
----------------
"return !(NoOpaques && Const->isOpaque())" ?
(assuming I got the logic right :-) )


Repository:
  rL LLVM

https://reviews.llvm.org/D25374





More information about the llvm-commits mailing list