[PATCH] D24989: Use profile info to set function section prefix to group hot/cold functions.

[Dehao Chen via llvm-commits]

danielcdh added inline comments.


================
Comment at: lib/Analysis/ProfileSummaryInfo.cpp:116
 
+void ProfileSummaryInfo::resetM(Module *newM) {
+  if (newM == M)
----------------
vsk wrote:
> Please spell the method name out to be explicit.
after rebasing, these changes are not necessary.


================
Comment at: lib/Analysis/ProfileSummaryInfo.cpp:120
+  M = newM;
+  delete Summary.release();
+}
----------------
vsk wrote:
> Why aren't the Hot/Cold count thresholds cleared?
after rebasing, these changes are not necessary.


================
Comment at: lib/Analysis/ProfileSummaryInfo.cpp:139
+  else
+    PSI->resetM(&M);
   return PSI.get();
----------------
vsk wrote:
> How is the call to "resetM" being tested by your test?
after rebasing, these changes are not necessary.


https://reviews.llvm.org/D24989