[PATCH] D24934: [LICM] Add support of a new optimization case to Loop Versioning for LICM + code clean up
silviu.baranga@arm.com via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 10 09:44:23 PDT 2016
sbaranga added a comment.
I just had a brief look through this, but I don't think LAA changes are correct (see the inline comment).
Also if there are non-functional changes here, could you split them into another review (this would make things easier to understand)?
Cheers,
Silviu
================
Comment at: lib/Analysis/LoopAccessAnalysis.cpp:664
+ } else {
+ CanDoRT = false;
+ }
----------------
Won't this just make canCheckPtrAtRT say that it can ignore all pointers with unknown bounds?
I think this would be incorrect for all other LAA users.
https://reviews.llvm.org/D24934
More information about the llvm-commits
mailing list