[PATCH] D25416: Add Chrono.h - std::chrono support header

Pavel Labath via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 10 09:05:26 PDT 2016


labath added a comment.

I am considering a somewhat different approach now. timespec does not seem to be defined on windows at all, and timeval only exists to support select() in the bsd socket emulation layer. I don't think llvm should be exposing such a platform-specific interface.  A better solution would be to identify things in lldb which need these functions, lower them into llvm and wrap in a platform-independent interface which speaks std::chrono (then the conversion utilities can remain in unix-specific code). This will require more cleanups on the lldb side though.

I'd still like to commit this without the part that deals with the fancy conversions - even without them, this supersedes llvm and lldb TimeValue, and replacing TimeValue with it seems pretty easy (I am almost done with that locally).


https://reviews.llvm.org/D25416





More information about the llvm-commits mailing list