[PATCH] D25304: cmake: Set the proper rpath in add_llvm_executable and llvm_add_library

[Peter Levine via llvm-commits]

plevine added inline comments.


================
Comment at: cmake/modules/AddLLVM.cmake:491
+    endif()
+    if (${CMAKE_PROJECT_NAME} MATCHES "LLVM")
+      set_target_properties( ${name} PROPERTIES BUILD_WITH_INSTALL_RPATH ON )
----------------
beanz wrote:
> This is definately not right. This condition will be false in clang and other sub-projects regardless of whether or not you're building against an installed LLVM. It might be sufficient to compare `CMAKE_INSTALL_PREFIX` against `LLVM_INSTALL_PREFIX`. The later is defined by LLVMConfig.cmake which is used by out-of-tree project builds. Writing the compare that way would also result in not having unnecissary extra rpaths.
> It might be sufficient to compare CMAKE_INSTALL_PREFIX against LLVM_INSTALL_PREFIX

This doesn't appear to be working.


https://reviews.llvm.org/D25304