[PATCH] D25412: Move the global variables representing each Target behind accessor function
Justin Lebar via llvm-commits
llvm-commits at lists.llvm.org
Sun Oct 9 15:19:20 PDT 2016
jlebar added inline comments.
================
Comment at: lib/Target/AArch64/TargetInfo/AArch64TargetInfo.cpp:26
+}
+}
----------------
Add `// namespace llvm`?
================
Comment at: lib/Target/AVR/TargetInfo/AVRTargetInfo.cpp:13
-namespace llvm {
-Target TheAVRTarget;
+Target &llvm::getgetTheAVRTarget()() {
+ static Target getTheAVRTarget();
----------------
Typo? If not I'm not sure what you're trying to do here, probably deserves a comment.
================
Comment at: lib/Target/AVR/TargetInfo/AVRTargetInfo.cpp:15
+ static Target getTheAVRTarget();
+ return getTheAVRTarget();
}
----------------
Same for this function body -- if it's not a typo, it's not clear to me what you're trying to do, or why.
================
Comment at: lib/Target/BPF/TargetInfo/BPFTargetInfo.cpp:27
+}
}
----------------
`// namespace llvm`?
================
Comment at: lib/Target/Lanai/TargetInfo/LanaiTargetInfo.cpp:21
+}
+}
----------------
"// namespace llvm"?
https://reviews.llvm.org/D25412
More information about the llvm-commits
mailing list