[PATCH] D25409: [lit] Remove semicolons in Python code

Brian Gesiak via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 9 13:55:12 PDT 2016


modocache created this revision.
modocache added reviewers: ddunbar, echristo, delcypher, beanz.
modocache added a subscriber: llvm-commits.
Herald added a subscriber: mehdi_amini.

Semicolons aren't necessary as statement terminators in Python, and
each of these uses are superfluous as they appear at the end of a line.
The convention is to not use semicolons where not needed, so remove them.


https://reviews.llvm.org/D25409

Files:
  utils/lit/lit/TestRunner.py
  utils/lit/lit/util.py


Index: utils/lit/lit/util.py
===================================================================
--- utils/lit/lit/util.py
+++ utils/lit/lit/util.py
@@ -114,8 +114,8 @@
 def checkToolsPath(dir, tools):
     for tool in tools:
         if not os.path.exists(os.path.join(dir, tool)):
-            return False;
-    return True;
+            return False
+    return True
 
 def whichTools(tools, paths):
     for path in paths.split(os.pathsep):
Index: utils/lit/lit/TestRunner.py
===================================================================
--- utils/lit/lit/TestRunner.py
+++ utils/lit/lit/TestRunner.py
@@ -503,7 +503,7 @@
     return out, err, exitCode, timeoutInfo
 
 def executeScript(test, litConfig, tmpBase, commands, cwd):
-    bashPath = litConfig.getBashPath();
+    bashPath = litConfig.getBashPath()
     isWin32CMDEXE = (litConfig.isWindows and not bashPath)
     script = tmpBase + '.script'
     if isWin32CMDEXE:


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D25409.74080.patch
Type: text/x-patch
Size: 938 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161009/2b950742/attachment.bin>


More information about the llvm-commits mailing list