[PATCH] D23566: [RISCV 8/10] Add support for all RV32I instructions

[Alex Bradbury via llvm-commits]

asb added inline comments.


================
Comment at: lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:262
 
+bool RISCVAsmParser::generateImmOutOfRangeError(
+    OperandVector &Operands, uint64_t ErrorInfo, int Lower, int Upper,
----------------
theraven wrote:
> If this is only used in this file, it might be better off as a function in an anonymous namespace rather than a method exposed in the header.
RISCVAsmParser is itself already in an anonymous namespace. Unless I'm misunderstanding the suggestion, I'm not seeing much advantage in splitting out this and other helpers. It also wouldn't match standard practice in other backends.


https://reviews.llvm.org/D23566