[PATCH] D25384: [ThinLTO] Record references to aliases to calls

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 7 22:47:55 PDT 2016


mehdi_amini accepted this revision.
mehdi_amini added a comment.

LGTM now!

Thanks.



================
Comment at: lib/Analysis/ModuleSummaryAnalysis.cpp:116
         if (!CalledFunction->hasName() || CalledFunction->isIntrinsic())
           continue;
         auto ScaledCount = BFI ? BFI->getBlockProfileCount(&BB) : None;
----------------
tejohnson wrote:
> mehdi_amini wrote:
> > What if we have an alias to an unnamed function?
> I thought these would all get named in the NameAnonGlobals pass? 
> 
> In fact, perhaps this should be an assert that we have a name?
Oh right, I forgot about that.


https://reviews.llvm.org/D25384





More information about the llvm-commits mailing list