[PATCH] D25345: [ThinLTO] Handle empty summaries during internalization

[Teresa Johnson via llvm-commits]

tejohnson added a comment.

In https://reviews.llvm.org/D25345#565108, @mehdi_amini wrote:

> In https://reviews.llvm.org/D25345#565040, @tejohnson wrote:
>
> > But this change is needed for now to keep the current model working
>
>
> "Keep the current model working" isn't exact: I believe it is broken since the recent addition of "false empty summaries" for module.
>  So have the current model working again now, you would need to revert this.


I was referring to the model of preventing importing and renaming by suppressing the summary. Which has other issues as discussed, but this change at least makes the current handling uniform.


https://reviews.llvm.org/D25345