[PATCH] D25300: ThinLTO: handles modules with empty summaries

[Mehdi AMINI via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: lib/LTO/ThinLTOCodeGenerator.cpp:239
+      // The module does not have an entry, it can't have a hash at all
+      return;
+
----------------
Is your question referring to this line?

If there is no entry for the module, it means it does not have a hash.


================
Comment at: test/ThinLTO/X86/empty_module_with_cache.ll:14
+; RUN:  -r=%t2.bc,_main,plx 
+; RUN: ls %t.cache | count 1
+
----------------
tejohnson wrote:
> mehdi_amini wrote:
> > tejohnson wrote:
> > > Why do we have 1 cache entry for llvm-lto2 but 2 for llvm-lto?
> > We haven't hooked the cache pruning apparently.
> I would expect llvm-lto2 to have more files in the cache without pruning. I guess with the current patch we should actually only have 1 since you are preventing caching for the empty module that has an empty summary (although I have a high-level question about that earlier)? So I guess the question is why we still get 2 for llvm-lto?
The pruning adds a timestamp file.


https://reviews.llvm.org/D25300