[PATCH] D24941: [libc++][tests] Fixing some issues in unordered container tests

Eric Fiselier via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 7 15:17:47 PDT 2016


EricWF added a comment.

This *almost* LGTM. The tests that have been converted to a throwing `_LIBCPP_ASSERT` need to be marked with `// UNSUPPORTED: libcpp-no-exceptions`

In https://reviews.llvm.org/D24941#554475, @iid_iunknown wrote:

> Yes, I can do this once I am done with my other tasks. May we do this refactoring in a separate review request to avoid a relatively big commit?


Absolutely. Refactorings are always welcome as multiple smaller patches.


https://reviews.llvm.org/D24941





More information about the llvm-commits mailing list