[LNT] r283614 - Better failure mode when we can't detect clang version

[Chris Matthews via llvm-commits]

Author: cmatthews
Date: Fri Oct  7 16:58:10 2016
New Revision: 283614

URL: http://llvm.org/viewvc/llvm-project?rev=283614&view=rev
Log:
Better failure mode when we can't detect clang version

Right now we submit data with order=0, which means when we can't detect
the compiler version all the data gets dumped onto version 0.  We don't
want data on 0, it makes all the graphs look funny.

In the case we can't detect compiler version, explode unless the user
has given us one.

Modified:
    lnt/trunk/lnt/tests/test_suite.py

Modified: lnt/trunk/lnt/tests/test_suite.py
URL: http://llvm.org/viewvc/llvm-project/lnt/trunk/lnt/tests/test_suite.py?rev=283614&r1=283613&r2=283614&view=diff
==============================================================================
--- lnt/trunk/lnt/tests/test_suite.py (original)
+++ lnt/trunk/lnt/tests/test_suite.py Fri Oct  7 16:58:10 2016
@@ -440,6 +440,15 @@ class TestSuiteTest(BuiltinTest):
                                        cc_info['cc_target'].split('-')[0])
         note('Using nickname: %r' % self.nick)
 
+        #  When we can't detect the clang version we use 0 instead. That
+        # is a horrible failure mode because all of our data ends up going
+        # to order 0.  The user needs to give an order if we can't detect!
+        if opts.run_order is None:
+            cc_info = self._get_cc_info()
+            if cc_info['inferred_run_order'] == 0:
+                fatal("Cannot detect compiler version. Specify --run-order"
+                      " to manually define it.")
+
         #  If we are doing diagnostics, skip the usual run and do them now.
         if opts.diagnose:
             return self.diagnose()