[PATCH] D25235: [ELF] - Do not crash if common symbol alignment set to value greater than UINT32_MAX.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 7 13:12:41 PDT 2016


ruiu added inline comments.


================
Comment at: ELF/InputFiles.cpp:405
       fatal(getFilename(this) + ": common symbol '" + Name +
-            "' alignment is 0");
+            "' alignment is 0 or too large");
     return elf::Symtab<ELFT>::X->addCommon(Name, Sym->st_size, Sym->st_value,
----------------
  "': invalid alignment: " + Twine(Sym->st_value

is probably more helpful.


https://reviews.llvm.org/D25235





More information about the llvm-commits mailing list