[PATCH] D24414: Conditionally eliminate library calls where the result value is not used

[David Li via llvm-commits]

davidxl added inline comments.


================
Comment at: lib/Transforms/Utils/CondDeadCallElimination.cpp:312
+  // A possible improvement is to handle the calls with return valued being
+  // used, if there is API for fast libcall implementation (without setting
+  // errno). We can use the same framework to direct calls that known
----------------
used,  if there is API .. ---> used. If there is an API ..


================
Comment at: lib/Transforms/Utils/CondDeadCallElimination.cpp:313
+  // used, if there is API for fast libcall implementation (without setting
+  // errno). We can use the same framework to direct calls that known
+  // errno-free to the new API calls.
----------------
errno). We ...  --> errno,  we  ...

Also, the description should be :

.. can use the same framework to direct/wrap the call to the fast API in the error free path, and leave the original call in the slow path.


https://reviews.llvm.org/D24414