[PATCH] D25291: [AArch64] Optionally use the reciprocal estimation machinery

[Renato Golin via llvm-commits]

rengolin added a comment.

In https://reviews.llvm.org/D25291#564558, @evandro wrote:

> In https://reviews.llvm.org/D25291#564540, @rengolin wrote:
>
> > Wait, Eric said there was an LTO problem with selecting it per sub-arch. I'd rather him review it first.
>
>
> This is a modification of the original patch to use the function attribute.


Right, ok. Let's wait for Eric's review to make sure it solves the problem he was seeing.

Still doesn't solve the problem of choosing it on other AArch64 cores upon analysis, nor offers a good way to test it (as James said).

Maybe we should do as Jojo said earlier and leave it as a hidden flag, disabled by default, so we can test on everyone's side before this goes live, even for M1.

cheers,
--renato


Repository:
  rL LLVM

https://reviews.llvm.org/D25291