[PATCH] D25333: [LV] Avoid rounding errors for predicated instruction costs

Matthew Simpson via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 7 08:11:40 PDT 2016


mssimpso added inline comments.


================
Comment at: lib/Transforms/Vectorize/LoopVectorize.cpp:6528
+      // models a copy at the end of each predicated block.
+      auto PhiCost = VF * TTI.getCFInstrCost(Instruction::PHI);
+
----------------
gilr wrote:
> Not sure the use of "auto" instead of "unsigned" adheres to [[ http://llvm.org/docs/CodingStandards.html#use-auto-type-deduction-to-make-code-more-readable | the coding guidelines for auto ]].
Good point, I'll make this explicit. Thanks, Gil!


https://reviews.llvm.org/D25333





More information about the llvm-commits mailing list