[PATCH] D25132: Invoke add-discriminator at -g0 -fsample-profile

[Dehao Chen via llvm-commits]

danielcdh added a comment.

In https://reviews.llvm.org/D25132#564464, @dnovillo wrote:

> Thanks, Dehao.  This LGTM now.  I'm not 100% sure about the code paths in *Dwarf*.cpp, but they look safe enough.  The only concern there would be any other code that also calls getDiscriminator, in which case, perhaps we could sink the DWARF version check into getDiscriminator and have getDiscriminator return ErrorOr.


Thanks for the reviews.

I grepped around the code base, looks like SampleProfile.cpp is the only transformation/analysis that uses getDiscriminator. Other callsites are only for output processing.

This patch needs to get in after https://reviews.llvm.org/D25133 is committed too ensure no test breakage. Could you help take a look at that too?


https://reviews.llvm.org/D25132