[PATCH] D25365: [ELF] - Do not crash on invalid local symbol.
Rafael EspĂndola via llvm-commits
llvm-commits at lists.llvm.org
Fri Oct 7 06:17:02 PDT 2016
Ah, I can actually get a crash with
.Lfoo = 42
and assembling with llvm-mc -save-temp-labels.
Given that that is not completely invalid, maybe we just just accept
and keep these symbols?
Cheers,
Rafael
On 7 October 2016 at 08:55, George Rimar <grimar at accesssoftek.com> wrote:
>>I am building a debug version to take a look, but how is this case
>>different from a local absolute? I.E., what code path prevents us from
>>crashing on those?
>>
>>Cheers,
>>Rafael
>
> Absolute symbols does not have empty names I think, so:
>
> if (!SymName.startswith(".L") && !SymName.empty())
> return true;
>
> George.
More information about the llvm-commits
mailing list