[PATCH] D25234: [LLD][ARM] Garbage collection support for .ARM.exidx sections

Fri Oct 7 05:15:44 PDT 2016

No worries. This LGTM. It is quite a bit cleaner. I wish other arches
used something like that instead of .eh_frame.

I will benchmark and open a bug if we need to try to recover the performance.

Cheers,
Rafael

On 7 October 2016 at 05:27, Peter Smith <peter.smith at linaro.org> wrote:
> peter.smith added a comment.
>
> The initial patch did start that way. The SHF_LINK_ORDER sections that become live may make other sections that have further SHF_LINK_ORDER dependencies live so it ends up needing to converge. The move to adding the reverse dependency came from an earlier review comment.
>
> I'll try and see what impact the extra field in InputSection has in terms of performance. I've not got a setup for benchmarking right now but I'll take a look at setting one up.
>
> Another possibility is to store the reverse dependency in a map so that only the ARM Target pays the performance cost.
>
>
> https://reviews.llvm.org/D25234
>
>
>