[PATCH] D25348: New utility to visualize optimization records

[Adam Nemet via llvm-commits]

anemet added a comment.

In https://reviews.llvm.org/D25348#564004, @hfinkel wrote:

> This is neat, thanks!


Thank you.

> So long as we're using Python, any though on using something like http://pygments.org/ to do syntax highlighting?

Yes, that was probably my main motivation too for going with Python ;).  I'll take a look in a follow-up.

> In any case, I suspect we'll want to change the interface a lot, but I'm happy for you to commit this and we can iterate in-tree.

Absolutely.



> hfinkel wrote in opt-viewer.py:19
> FWIW, we have an llvm-cxxfilt tool, perhaps we should use it?

I was thinking the same thing but I don't think that we currently install that in the macOS toolchain :(

> hfinkel wrote in opt-viewer.py:85
> <a tag here is missing its closing >

Yeah, I am very loose with those.  Let me fix them before committing.

https://reviews.llvm.org/D25348