[PATCH] D23464: [PR28367][Reassociation] Avoid iterator invalidation when negating value.

[Charles Li via llvm-commits]

tigerleapgorge added a comment.

In https://reviews.llvm.org/D23464#520974, @aditya_nandakumar wrote:

> Thanks Chad for reverting r258830. I apologize I didn’t see this email earlier.
>
> This revert is causing some codegen regressions - I’ll look into this.


Hello Aditya,

I came across a SLP vectorizer ICE bug related to this commit.
I opened a LLVM bug but could not add you into the CC list.
https://llvm.org/bugs/show_bug.cgi?id=30626

TLDR version on the history of this crash.

1. ICE started at commit r253240.
2. ICE went away at commit r258830.
3. ICE resurfaced when commit r258830 was reverted at r278938.
4. As of today, this ICE still exists.

I would greatly appreciate your insight.

Thank you.


https://reviews.llvm.org/D23464