[PATCH] D24896: [safestack] Require TargetMachine to be provided.

Andy Kaylor via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 6 14:22:56 PDT 2016


andrew.w.kaylor added a comment.

It looks like the explicit triples are being used in the tests in the non-arch-specific directory simply to force the tests to be run for both x86-64 and i386 targets.  This is great for x86, but it means that these tests aren't run at all against other targets, even when another target is the default for the build.  That seems bad.

I would be inclined to remove the explicit triple from these tests and look for another way to exercise the 32-bit x86 targets.  A quick and dirty way to do this would be to duplicate the tests as they are now in the X86 directory and leave a version without an explicit triple in the non-arch directory.  That's not a good long-term solution but I'm not sure what other options are available.  There must be other tests that have this same dilemma though.

Is it possible that a much smaller set of tests could verify whatever i386-specific behavior needs to be tested?


Repository:
  rL LLVM

https://reviews.llvm.org/D24896





More information about the llvm-commits mailing list