[PATCH] D996: hasPath

[Eugene Zelenko via llvm-commits]

Hi, Chandler !

On Wed, Oct 5, 2016 at 7:04 PM, Chandler Carruth <chandlerc at gmail.com> wrote:
> On Wed, Oct 5, 2016 at 1:25 PM Eugene Zelenko via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
>>
>> Eugene.Zelenko added a comment.
>> This revision now requires review to proceed.
>>
>> Looks like patch was not committed.
>
>
> I would like to ask that you are a bit less eager with auditing all of
> phabricator for patches that haven't been committed. I think this is
> starting to add more noise than signal.
>
> In particular, I would suggest only pinging in this way if there is some
> functionality you are interested in seeing specifically and if you have
> verified that in fact it doesn't exist in tree, not just that the
> phabricator review isn't closed.
>
> Keep in mind, phabricator is not the system of record for LLVM. It is just a
> tool we use to make writing and reading code reviews a bit easier.

I think general housekeeping is good idea for Phabricator too.

Many accepted reviews were not closed because Differential revision
was not mentioned in commit message or was specified in wrong way. It
may be sign of not so good documentation. It will be good idea to
consider to match accepted Differential revisions with actual commits.

I'll be good idea to ping authors/reviewers in other cases. Some
revisions may be just forgotten. If some of them are obsolete, they
should be abandoned.

Eugene.