[PATCH] D25315: [Object/ELF] - Do section header sh_offset/sh_size values check once during object loading.

[Rafael Ávila de Espíndola via llvm-commits]

rafael requested changes to this revision.
rafael added a comment.
This revision now requires changes to proceed.

I don't think we should do this. Eagerly checking for errors means that a program would be unable to look at the file even if it is not hitting that particular corruption.

For example, at some point llvm-readobj should be able to just report a broken section offset and keep going. This makes it impossible.

Looks like what is needed is a dyns() function that return a Elf_Dyn range. Maybe implement it with a template so that rels() relas() can share the code?


https://reviews.llvm.org/D25315