[llvm] r283434 - [ValueTracking] Teach computeKnownBits and ComputeNumSignBits to look through ExtractElement.

[Bjorn Pettersson via llvm-commits]

Author: bjope
Date: Thu Oct  6 04:56:21 2016
New Revision: 283434

URL: http://llvm.org/viewvc/llvm-project?rev=283434&view=rev
Log:
[ValueTracking] Teach computeKnownBits and ComputeNumSignBits to look through ExtractElement.

Summary:
The computeKnownBits and ComputeNumSignBits functions in ValueTracking can now do a simple look-through of ExtractElement.

Reviewers: majnemer, spatel

Subscribers: llvm-commits

Differential Revision: https://reviews.llvm.org/D24955

Added:
    llvm/trunk/test/Analysis/ValueTracking/signbits-extract-elt.ll
Modified:
    llvm/trunk/lib/Analysis/ValueTracking.cpp

Modified: llvm/trunk/lib/Analysis/ValueTracking.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/ValueTracking.cpp?rev=283434&r1=283433&r2=283434&view=diff
==============================================================================
--- llvm/trunk/lib/Analysis/ValueTracking.cpp (original)
+++ llvm/trunk/lib/Analysis/ValueTracking.cpp Thu Oct  6 04:56:21 2016
@@ -1389,6 +1389,13 @@ static void computeKnownBitsFromOperator
       }
     }
     break;
+  case Instruction::ExtractElement:
+    // Look through extract element. At the moment we keep this simple and skip
+    // tracking the specific element. But at least we might find information
+    // valid for all elements of the vector (for example if vector is sign
+    // extended, shifted, etc).
+    computeKnownBits(I->getOperand(0), KnownZero, KnownOne, Depth + 1, Q);
+    break;
   case Instruction::ExtractValue:
     if (IntrinsicInst *II = dyn_cast<IntrinsicInst>(I->getOperand(0))) {
       const ExtractValueInst *EVI = cast<ExtractValueInst>(I);
@@ -2220,6 +2227,13 @@ unsigned ComputeNumSignBits(const Value
     // FIXME: it's tricky to do anything useful for this, but it is an important
     // case for targets like X86.
     break;
+
+  case Instruction::ExtractElement:
+    // Look through extract element. At the moment we keep this simple and skip
+    // tracking the specific element. But at least we might find information
+    // valid for all elements of the vector (for example if vector is sign
+    // extended, shifted, etc).
+    return ComputeNumSignBits(U->getOperand(0), Depth + 1, Q);
   }
 
   // Finally, if we can prove that the top bits of the result are 0's or 1's,

Added: llvm/trunk/test/Analysis/ValueTracking/signbits-extract-elt.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Analysis/ValueTracking/signbits-extract-elt.ll?rev=283434&view=auto
==============================================================================
--- llvm/trunk/test/Analysis/ValueTracking/signbits-extract-elt.ll (added)
+++ llvm/trunk/test/Analysis/ValueTracking/signbits-extract-elt.ll Thu Oct  6 04:56:21 2016
@@ -0,0 +1,28 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt < %s -instsimplify -S | FileCheck %s
+
+; If computeKnownBits can do a simple look-through for extractelement
+; then instsimplify will know that %elt1 is non-negative at icmp.
+define i1 @computeKnownBits_look_through_extractelt(<2 x i8> %vecin) {
+; CHECK-LABEL: @computeKnownBits_look_through_extractelt(
+; CHECK-NEXT:    ret i1 false
+;
+  %vec = zext <2 x i8> %vecin to <2 x i32>
+  %elt1 = extractelement <2 x i32> %vec, i32 1
+  %bool = icmp slt i32 %elt1, 0
+  ret i1 %bool
+}
+
+; If computeNumSignBits can do a simple look-through for extractelement
+; then instsimplify will remove the ashr.
+define i32 @computeNumSignBits_look_through_extractelt(<2 x i1> %vecin) {
+; CHECK-LABEL: @computeNumSignBits_look_through_extractelt(
+; CHECK-NEXT:    [[VEC:%.*]] = sext <2 x i1> [[VEC:%.*]]in to <2 x i32>
+; CHECK-NEXT:    [[ELT0:%.*]] = extractelement <2 x i32> [[VEC]], i32 0
+; CHECK-NEXT:    ret i32 [[ELT0]]
+;
+  %vec = sext <2 x i1> %vecin to <2 x i32>
+  %elt0 = extractelement <2 x i32> %vec, i32 0
+  %ashr = ashr i32 %elt0, 5
+  ret i32 %ashr
+}