[PATCH] D24425: DebugInfo: support for DWARFv5 DW_AT_alignment attribute

[Victor Leschuk via llvm-commits]

vleschuk added inline comments.


> aprantl wrote in DwarfCompileUnit.cpp:779
> Can this ever be 0?

I think it can be NULL: class DbgVariable doesn't check its DILocalVariable * member for being NULL when being constructed or accessed.

> aprantl wrote in Dwarf.cpp:152
> For consistency with the rest of the file, I would put this on the same line.

See DW_AT_MIPS_software_pipeline_depth it has same formatting (as requires coding standard and clang-format), so we already have this file formatting inconsistent. I'd prefer keeping clang-format silent on changes rather them keeping current formatting intact manually.

https://reviews.llvm.org/D24425