[PATCH] D25299: Add StringRef::find_lower and contains_lower

[Chandler Carruth via llvm-commits]

chandlerc added a comment.

Why not implement find_lower the same way find is implemented? It doesn't seem too hard? Just define a local version of memcmp that does ascii_tolower on each character before comparing and doing the same thing prior to inserting into the skip table or looking up a skip distance in it?

Could try to share the code if you really want with a templated helper that calls a passed-in callable on each character, but doesn't really seem worth it to me.


https://reviews.llvm.org/D25299