[PATCH] D25022: Register Calling Convention - CodeGen Basic Additions

[Reid Kleckner via llvm-commits]

rnk added inline comments.


> X86CallingConv.h:47
> +inline bool CC_X86_RegCall_Error(unsigned &, MVT &, MVT &,
> +  CCValAssign::LocInfo &, ISD::ArgFlagsTy &,
> +  CCState &) {

format

> X86CallingConv.h:49-50
> +  CCState &) {
> +  llvm_unreachable("LLVM x86 RegCall calling convention implementation" \
> +    " doesn't support long double and mask types yet.");
> +  return false; // gracefully continue the search - fallback to stack.

Use report_fatal_error so that it fails in release builds

> oren_ben_simhon wrote in X86CallingConv.td:1120
> Yes, SSE disabled is possible. I will make similar changes to what you did in r282819.
> I wanted to ask you, why did you update the returned SaveList in x86RegisterInfo.cpp but not the corresponding RegMask?

Hm, that's an oversight, but I guess it isn't observable because a function with SSE disabled won't have any XMM* registers live across the call.

Repository:
  rL LLVM

https://reviews.llvm.org/D25022