[PATCH] D24076: [ARM] Use __rt_div functions for DIVREM on Windows

[Saleem Abdulrasool via llvm-commits]

compnerd accepted this revision.
compnerd added inline comments.


> dbzchk.ll:144
>  ; CHECK-CFG-ASM: bl __rt_udiv
> -; CHECK-CFG-ASM: pop.w {{{.*}}, r11, pc}
> +; CHECK-CFG-ASM: pop.w {r11, pc}
>  

This is amazing.  Glad to see this improved.

> divmod-eabi.ll:45
>  ; WINDOWS: __rt_sdiv
> -; WINDOWS-DEFAULT: mls [[rem:r[0-9]+]], r0,
> -; WINDOWS-DEFAULT: adds [[sum:r[0-9]+]], [[rem]], r0
> -; WINDOWS-O0: mov [[div:r[0-9]+]], r0
> -; WINDOWS-O0: mls [[rem:r[0-9]+]], [[div]],
> +; WINDOWS: __rt_sdiv
> +; WINDOWS-DEFAULT: add [[sum:r[0-9]+]], r1

Hmm, it would be nice to see that we can still generate the hardware division.  But, I don't think that we need to hold up on that.

https://reviews.llvm.org/D24076