[PATCH] D25290: Improve the debug-info test created in r274263

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 5 12:23:55 PDT 2016


dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Great - thanks!

(I see now, that the test is already being run for several different architectures - as that's the case, and you did have the right CHECKs for each architecture (& the other tests in the file do test several architectures), feel free to add those back in - seeing only the (somewhat mangled) diff, I wasn't sure if you'd created a test case to specifically run on multiple architectures, extra test invocations, etc - but since this file is already being invoked for all those different targets, CHECKing the result on them seems nice to have)


https://reviews.llvm.org/D25290





More information about the llvm-commits mailing list