[PATCH] D25288: [X86] Fix intel syntax push parsing bug
David Majnemer via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 5 12:01:36 PDT 2016
majnemer added inline comments.
> X86AsmParser.cpp:2799
> + if (Mnemonic == "push" && Operands.size() == 2) {
> + X86Operand *X86Op = static_cast<X86Operand *>(Operands[1].get());
> + if (X86Op->isImm()) {
`auto *`
> X86AsmParser.cpp:2802
> + // If it's not a constant fall through and let remainder take care of it.
> + const MCConstantExpr *CE = dyn_cast<MCConstantExpr>(X86Op->getImm());
> + unsigned Size = getPointerWidth();
`const auto *`
https://reviews.llvm.org/D25288
More information about the llvm-commits
mailing list