[PATCH] D25262: Add an llvm-opt-report tool to generate basic source-annotated optimization summaries
Adam Nemet via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 5 09:20:15 PDT 2016
anemet accepted this revision.
anemet added a comment.
This revision is now accepted and ready to land.
This is really great, LGTM!
> OptReport.cpp:118
> +
> + for (auto &RootChild : *Root) {
> + auto *Key = dyn_cast<yaml::ScalarNode>(RootChild.getKey());
I think I understand that you're only interested to partially interpret the records but it would be good to add a comment why you don't use the YAML<->class functionality of the YAML I/O library.
https://reviews.llvm.org/D25262
More information about the llvm-commits
mailing list