[PATCH] D25211: [ARM] Add Cortex-R52 target to LLVM

[Renato Golin via llvm-commits]

rengolin added inline comments.


> ARMTargetParser.def:99
> +          FK_NEON_FP_ARMV8, (ARM::AEK_SEC | ARM::AEK_MP | ARM::AEK_VIRT | ARM::AEK_HWDIVARM | ARM::AEK_HWDIV |
> +                             ARM::AEK_DSP | ARM::AEK_CRC))
>  ARM_ARCH("armv8-m.base", AK_ARMV8MBaseline, "8-M.Baseline", "v8m.base",

Are this all minimum requirements? Or just some common implementation?

> ARMTargetParser.def:226
>               (ARM::AEK_MP | ARM::AEK_HWDIVARM))
> +ARM_CPU_NAME("cortex-r52", AK_ARMV8R, FK_NEON_FP_ARMV8, false, ARM::AEK_CRC)
>  ARM_CPU_NAME("sc300", AK_ARMV7M, FK_NONE, false, ARM::AEK_NONE)

is CRC guaranteed to be in every R52?

> TargetParser.cpp:726
>      return ARM::PK_R;
> +  case ARM::AK_ARMV8R:
> +    return ARM::PK_R;

Merge with AK_ARMV7R case

> ARM.td:484
> +                                                       FeatureDSP,
> +                                                       FeatureCRC,
> +                                                       FeatureMP,

Same question here about minimum support.

https://reviews.llvm.org/D25211