[PATCH] D25255: Add a c_str() method to StringRef, similar to data() but asserting if the string isn't null terminated (NFC)

[Zachary Turner via llvm-commits]

Can you use %*s format specifier in those cases?

printf("%*s", s.size(), s.data());
On Tue, Oct 4, 2016 at 3:34 PM Mehdi AMINI <mehdi.amini at apple.com> wrote:

> mehdi_amini added a comment.
>
> In https://reviews.llvm.org/D25255#561566, @zturner wrote:
>
> > Not sure how I feel about this.  It's convenient, but it has potential
> for abuse.  Where did you run into issues porting code to `StringRef` that
> this solves?
>
>
> I ran into this with "printf" like API at some point, or with places that
> can't be converted to StringRef because of space constraint, like
> MachineOperand. So you're out of the IR and you have to use .data() to
> initialize the MO. Later you may construct a StringRef from this "const
> char *" again.
>
> >   I've done a lot of `StringRef` porting in LLDB by now, and I've always
> managed to find a solution to this.  Usually it involves trickling the
> `StringRef` changes down further
>
> Usually that's what I do, yes. The problem is when you reach some cases
> like above.
>
>
> https://reviews.llvm.org/D25255
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161004/c6476d77/attachment.html>