[PATCH] D24706: [ELF] - Partial support of --gdb-index command line option (Part 1).

[Eric Christopher via llvm-commits]

echristo added a comment.

I think calling the file SplitDebugInfo.cpp is a bit of a misnomer, there's nothing related to fission/split-dwarf/etc in it other than a couple of references. Also not sure why we need yet another dwarf parser here rather than using the one in llvm?

Looks fine otherwise though.

-eric



> SplitDebugInfo.cpp:290
> +    // When using -gsplit-dwarf, .debug_info section contains a single
> +    // DW_TAG_compile_unit DIE, with no children. Here we create DIE parcer
> +    // that reads abbreviation entry and list of atributes.

"parcer" -> "parser"

> gdb-index.s:2
> +## gdb-index-a.elf and gdb-index-b.elf are a test.o and test2.o renamed,
> +## were generated in a next way:
> +## test.cpp:

"were generated in this way"

https://reviews.llvm.org/D24706