[PATCH] D25253: [codeview] Translate bitpiece metadata to DEFRANGE_SUBFIELD* records

[Adrian McCarthy via llvm-commits]

amccarth added a comment.

Looks fine overall.  I just have a couple inline questions.



> SymbolRecord.h:813
>  
> +  enum : uint16_t { IsSubfieldFlag = 1 << 15, OffsetInParentMask = 0xFFF };
> +

Is the mask correct?  Three nybbles kinda looks like a typo, and it's used on the StructOffset which is 15 bits, so I expected `0x7FFF`.  If the mask is correct, then maybe `0x0FFF` would be clearer.

> pieces.ll:2
> +; RUN: llc < %s | FileCheck %s --check-prefix=ASM
> +; RUN: llc < %s -filetype=obj | llvm-readobj -codeview | FileCheck %s --check-prefix=OBJ
> +

Is it redundant to check both the ASM and OBJ output?  Your change affects the ASM directly.  The OBJ check seems like it's covering ground that should already be handled in the llvm-readobj tests.  Am I missing something?

https://reviews.llvm.org/D25253