[llvm] r283254 - Revert r283248. It caused failures in the hexagon buildbots.

[Krzysztof Parzyszek via llvm-commits]

The compiler built by the Hexagon buildbots only has Hexagon backend in 
it. I.e. no x86 or anything else. Since these tests specify mtriple, one 
fix may be to add REQUIRES for the target specified in mtriple.

-Krzysztof


On 10/4/2016 3:57 PM, David L Kreitzer via llvm-commits wrote:
> Author: dlkreitz
> Date: Tue Oct  4 15:57:19 2016
> New Revision: 283254
>
> URL: http://llvm.org/viewvc/llvm-project?rev=283254&view=rev
> Log:
> Revert r283248. It caused failures in the hexagon buildbots.
>
> Modified:
>     llvm/trunk/lib/CodeGen/SafeStack.cpp
>
> Modified: llvm/trunk/lib/CodeGen/SafeStack.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SafeStack.cpp?rev=283254&r1=283253&r2=283254&view=diff
> ==============================================================================
> --- llvm/trunk/lib/CodeGen/SafeStack.cpp (original)
> +++ llvm/trunk/lib/CodeGen/SafeStack.cpp Tue Oct  4 15:57:19 2016
> @@ -358,8 +358,9 @@ bool SafeStack::IsSafeStackAlloca(const
>
>  Value *SafeStack::getOrCreateUnsafeStackPtr(IRBuilder<> &IRB, Function &F) {
>    // Check if there is a target-specific location for the unsafe stack pointer.
> -  if (Value *V = TL->getSafeStackPointerLocation(IRB))
> -    return V;
> +  if (TL)
> +    if (Value *V = TL->getSafeStackPointerLocation(IRB))
> +      return V;
>
>    // Otherwise, assume the target links with compiler-rt, which provides a
>    // thread-local variable with a magic name.
> @@ -392,7 +393,9 @@ Value *SafeStack::getOrCreateUnsafeStack
>  }
>
>  Value *SafeStack::getStackGuard(IRBuilder<> &IRB, Function &F) {
> -  Value *StackGuardVar = TL->getIRStackGuard(IRB);
> +  Value *StackGuardVar = nullptr;
> +  if (TL)
> +    StackGuardVar = TL->getIRStackGuard(IRB);
>    if (!StackGuardVar)
>      StackGuardVar =
>          F.getParent()->getOrInsertGlobal("__stack_chk_guard", StackPtrTy);
> @@ -749,9 +752,7 @@ bool SafeStack::runOnFunction(Function &
>      return false;
>    }
>
> -  if (!TM)
> -    report_fatal_error("Target machine is required");
> -  TL = TM->getSubtargetImpl(F)->getTargetLowering();
> +  TL = TM ? TM->getSubtargetImpl(F)->getTargetLowering() : nullptr;
>    SE = &getAnalysis<ScalarEvolutionWrapperPass>().getSE();
>
>    ++NumFunctions;
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, 
hosted by The Linux Foundation