[PATCH] D25234: [LLD][ARM] Garbage collection support for .ARM.exidx sections

[Rui Ueyama via llvm-commits]

ruiu added inline comments.


> InputFiles.cpp:259
>    }
> +  // .ARM.exidx sections have a reverse dependency on the InputSection they
> +  // have a SHF_LINK_ORDER dependency, this is identified by the sh_link.

Can you make this a separate function, say, initializeARMLinkOrderSection, and call it from ObjectFile::parse?

Please do this only when Config->GcSections is true.

> InputSection.h:232
> +  // InputSection that is dependent on us (reverse dependency for GC)
> +  InputSectionBase<ELFT> *dependentSection = nullptr;
> +

Variable names should start with uppercase letters.

Is it guaranteed that a section has at most one corresponding .ARM.exidx section?

> arm-exidx-gc.s:13
> +
> + .syntax unified
> + .section .text.func1, "ax",%progbits

I don't know much about ARM assembly, but do you actually need this amount of assembly code to test your feature?

https://reviews.llvm.org/D25234