[PATCH] D25232: [ELF] Do not join input sections when linker creates relocatable object file (-r option)

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 4 13:18:09 PDT 2016


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



> Writer.cpp:94
>  StringRef elf::getOutputSectionName(InputSectionBase<ELFT> *S) {
>    StringRef Name = S->Name;
> +  if (Config->Relocatable)

Please replace Name with S->Name in this function. I think it made sense when it was S->getName() but not anymore.

Repository:
  rL LLVM

https://reviews.llvm.org/D25232





More information about the llvm-commits mailing list